"order by" with datedesc should not use positional arguments in SQL

[julien]

There're two problems in the way the "rss.config.datedesc" config value is handled in the cls/items.php file. First, it uses positional arguments in the order by clause to access the "ts" column, which will prove to be difficult to maintain in further evolutions. Second, in one occasion it uses the "ts" column and on another occasion it uses the column "i.added".

I will attach a patch that corrects both problems.

[julien]

the promised patch that address both problems

[mdodoo]

Fixed by [650]. Thanks for the patch!

[julien]

Reopened ticket because the fix in [650] is incorrect for feed.php. On line 512, it has "ts desc" where it should be "ts asc".

[mbonetti]

Fixed in [655] (I hope this is correct)