Ticket #502 (new defect)

Opened 5 months ago

Last modified 5 months ago

Tiny bug in Mark All Read Plugin Version 0.6 from svn

Reported by: reporter Assigned to: mbonetti
Priority: normal Milestone: Gregarius 0.5.5
Component: BUGS Version: 0.5.5
Severity: normal Keywords:
Cc: fdonelly@hotmail.com

Description

I noticed on my install that the 'mark all read' plugin has a small bug.

The Sidebar 'Display a mark read link for feeds' option did not create a clickable link. The fix was simply to change the quoting, and I have only done a couple of really simple tests to check it works.

Change History

02/15/08 11:38:59 changed by reporter

My diff as I can't attach a file:

*** ~/markallread.php.orig 2008-02-15 21:09:52.000000000 +1100 --- plugins/markallread.php 2008-02-15 21:10:14.000000000 +1100 *************** *** 84,90 ****

} $options = rss_plugins_get_option( MARKALLREAD_CONFIG_OPTIONS ); if( $options & MARKALLREAD_OPTION_LINK_FEED )

! return "<a title='".('Mark This Feed as Read')."\" href=\"". getPath() ."feed.php?metaaction=ACT_MARK_CHANNEL_READ&amp;channel=" . $GLOBALSrss?->currentFeedsFeed-> id . "\" onclick=\"return _markallread(this,'feed','" . rss_feeds_feed_title() . "');\">" . $existingText . '</a>';

else

return $existingText;

}

--- 84,90 ----

} $options = rss_plugins_get_option( MARKALLREAD_CONFIG_OPTIONS ); if( $options & MARKALLREAD_OPTION_LINK_FEED )

! return "<a title=\"".('Mark This Feed as Read')."\" href=\"". getPath() ."feed.php?metaaction=ACT_MARK_CHANNEL_READ&amp;channel=" . $GLOBALSrss?->currentFeedsFeed-> id . "\" onclick=\"return _markallread(this,'feed','" . rss_feeds_feed_title() . "');\">" . $existingText . '</a>';

else

return $existingText;

}