support empty title RSS feeds

[salvatore@…]

Hi guys, I created a patch to support RSS feeds with empty title (TAG: <title></title>). Title is set with "UNTITLED" keyword and link.

FILE: util.php LINE: 461

BEFORE PATCH:

elseif (is_object($rss) && array_key_exists('title', $rss->channel)) {
    $title = rss_real_escape_string($rss->channel['title']);
}

AFTER PATCH:

elseif (is_object($rss) && array_key_exists('title#', $rss->channel)) {
    if (array_key_exists('title',$rss->channel)) {
        $title = rss_real_escape_string($rss->channel['title']);
    } else {
        $title = "UNTITLED - ".rss_real_escape_string($rss->channel['link']);
    }
}

Regards, Salvatore

[mdodoo]

The title is a required element in both RSS 1.0 and RSS 2.0. Can you provide an example of a RSS feed that lacks a title?

[salvatore@…]

This feed lacks required elements:

http://addpost.ru/rss.xml

<?xml version="1.0" encoding="windows-1251"?>
<rss version="2.0" xmlns:dc="http://purl.org/dc/elements/1.1/">
<channel>
<title></title>
<link>http://addpost.ru/</link>
<language>ru</language>
<description></description>
<generator>DataLife Engine</generator>

Regards, Salvatore

[mdodoo]

That feed has other problems as well (and is also not worksafe'''). I did create a RSS feed sans title from my own blog and was unable to add it to Gregarius.

Rather than adding "UNTITLED" to untitled feeds, I think it would be a better idea if Gregarius just left the title element empty, if possible, for purposes of localization.

[mdodoo]

Fixed by [1594].