Ticket #414 (closed enhancement: fixed)

Opened 2 years ago

Last modified 10 months ago

patch to lilina to allow for title-click-expansion while a page is loading

Reported by: Disconnect Assigned to: mdodoo
Priority: low Milestone: Gregarius 0.5.5
Component: FEATURES Version:
Severity: normal Keywords: lilina
Cc: sfx2000@gmail.com

Description

I'll attach the related files, but this patch allows you to click the title of an article to expand it while the page is still loading. (Now, with added Expand/Collapse button goodness.)

Partially tested under IE, seems to work but I don't think IE is rendering before the whole page has loaded. But I tested the expand/collapse button as well as title/folder expansions without finding any issues.)

Attachments

lilina.diff (5.6 kB) - added by Disconnect on 06/07/06 17:58:05.
Patch to lilina theme (delete lilina.js, broken into header and footer)

Change History

06/07/06 17:58:05 changed by Disconnect

  • attachment lilina.diff added.

Patch to lilina theme (delete lilina.js, broken into header and footer)

10/11/06 07:43:40 changed by mdodoo

  • owner changed from mbonetti to mdodoo.
  • status changed from new to assigned.

I will take a look at this.

08/23/07 08:35:01 changed by mdodoo

  • status changed from assigned to closed.
  • resolution set to fixed.

Tested in Firefox 2.0.0.6 (Linux), Firefox 3.0a7 (WinXP) and IE7 (WinXP). Seemed to work fine, so I committed it in [1747].

09/19/07 15:39:49 changed by reporter

  • cc set to sfx2000@gmail.com.
  • keywords set to lilina.
  • status changed from closed to reopened.
  • resolution deleted.

Re-opening...

Since lilina.js has been deleted, you will get many 404 errors in server log.

Looks like the index.php patch is only partially implemented. Need to change:

<script type="text/javascript" src="<?php echo getThemePath();?>/js/lilina.js">

to

<script type="text/javascript" src="<?php echo getThemePath();?>/js/lilina_footer.js">

09/19/07 18:54:29 changed by cfriesen

  • status changed from reopened to closed.
  • resolution set to fixed.

Fixed in [1755].

(I was wondering where those 404 errors were coming from all of a sudden.)