Ticket #354 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Username/Passwords in URLs need to be URL-decoded

Reported by: Rod Begbie <rod-gregarius@…> Owned by: mbonetti
Priority: normal Milestone: Gregarius 0.5.5
Component: BUGS Version:
Severity: minor Keywords: coots-must-fix
Cc:

Description

Some sites' RSS feeds require authentication using an email address as the username (eg. Daring Fireball -- http://daringfireball.net/members/info). Currently, entering this URL:

http://foo%40example.com:password@daringfireball.net/feeds/rss

Into Gregarius causes Snoopy to try and authenticate with the literal username "foo%40example.com", which fails.

The username and password need to be urldecoded before being base64'd.

I'll attach a patch momentarily.

Attachments

urldecode.patch (1.0 kB) - added by Rod Begbie <rod-gregarius@…> 3 years ago.
URLDecode patch

Change History

Changed 3 years ago by Rod Begbie <rod-gregarius@…>

URLDecode patch

Changed 3 years ago by anonymous

  • keywords coost-must-fix added

Changed 3 years ago by sdcosta

  • keywords coots-must-fix added; coost-must-fix removed

There was a typo in this keyword.

Changed 3 years ago by sdcosta

  • status changed from new to closed
  • resolution set to fixed

Fixed in [1346] Thanks for reporting and for the patch.

Note: See TracTickets for help on using tickets.