Ticket #240 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Editing Newly Added feed with Firefox Livelines Extension

Reported by: Carthik <mail@…> Owned by: mbonetti
Priority: normal Milestone: Gregarius 0.5.5
Component: BUGS Version:
Severity: normal Keywords:
Cc: mail@…

Description

After adding a new feed with the help of the Livelines firefox extension, clicking on the "Edit" link on the Gregarius page that loads immediately, tries to take me to the following URL, for example: http://carthik.net/vartakal/admin/sub/http://feeds.feedburner.com/jonwatson/index.php?domain=feeds&action=edit&cid=41

Is there something that can be done to correct this?

Change History

Changed 4 years ago by sdcosta

  • status changed from new to closed
  • resolution set to fixed

Fixed in [988]. Thanks for reporting...

Changed 4 years ago by mmlange@…

  • status changed from closed to reopened
  • resolution fixed deleted

This bug seems to be broken again with changeset [988]. Here is a patch to fix it: 

--- admin/channels.php  2005-11-08 15:26:44.000000000 -0600
+++ admin/channels.php.fixed      2005-11-08 15:26:37.000000000 -0600
@@ -261,7 +261,7 @@
                                LBL_ADMIN_OPML_IMPORT_FEED_INFO,
                                        htmlentities($label),"/$flabel")
                                        . LBL_ADMIN_OK
-                                       . "&nbsp;[<a href=\"".getPath()."admin/index.php?domain=".CST_ADMIN_DOMAIN_CHANNEL
+                                       . "&nbsp;[<a href=\"".getPath()."index.php?domain=".CST_ADMIN_DOMAIN_CHANNEL
                                                ."&amp;action=edit&amp;cid=$newCid\">"
                                        . LBL_ADMIN_EDIT
                                        ."</a>]",

Changed 4 years ago by anonymous

  • status changed from reopened to closed
  • resolution set to fixed

Matthew, thanks. This time it's fixed for good :) (in [1007], that is)

Changed 4 years ago by sdcosta

Sorry, this was my mistake for not double checking.

I think the same thing needs to be done a few lines lower down. As a test case try the following URL

http://example.com/rss/admin/sub/http://slashdot.org

Of course livelines will not give us an html URL, but there could be other cases...

Made the change in [1008].

Note: See TracTickets for help on using tickets.