Ticket #20 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

area to right of clickable images is also clickable

Reported by: Martey <martey@…> Owned by: mdodoo
Priority: low Milestone: Gregarius 0.5.5
Component: BUGS Version:
Severity: normal Keywords:
Cc:

Description

When using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4 (but not IE6), the area to the right of images that are embedded in feeds while also being clickable (enclosed by an A tag) is also clickable.

Change History

Changed 3 years ago by mbonetti

I doubt there is much I can do about this one: the problem here is that the images inside the items are displayed as block-level elements (to avoid having them inline with the text). Thus, anchors around an image are also displayed as a block-level elements, hence the clickable white space, which is quite annoying, I must admit.

You could avoid this by removing or commenting out the line

div.content img { display: block; }

from css/.../layout.css

Changed 3 years ago by mbonetti

  • milestone set to Gregarius 0.4.4

Changed 3 years ago by mdodoo

Adding

div.content a img { display:inline; }

to layout.css removes the clickable space, but will display clickable images inline. The only feed I read that uses clickable images on a regular basis is Engadget, and they do not put images in the midst of paragraphs, so it looks okay. I recognize that other people might have feeds like this, so I am hesitant about adding it to the repository.

This problem could be solved if rss.input.allowed included the "align" attribute in images. Unfortunately, this causes problems when left-aligned images are longer than the content div (it creates an ugly indentation effect). This could be solved by changing the "clear:right" in "div #items li" to "clear:both," but that causes problems with the sidebar. It might be possible to rig together some Javascript to solve the problem.

Changed 3 years ago by mdodoo

  • cc mdodoo added

Changed 3 years ago by mbonetti

  • priority changed from normal to low

Changed 3 years ago by mdodoo

  • cc mdodoo removed
  • owner changed from mbonetti to mdodoo
  • status changed from new to assigned

Changed 3 years ago by mdodoo

  • milestone changed from Gregarius 0.4.4 to Gregarius 0.5.2

Changed 3 years ago by mbonetti

  • milestone changed from Gregarius 0.5.2 to Gregarius 0.5.3

Let's do this via a plugin and get it out of the way.

Changed 3 years ago by mdodoo

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.