Ticket #194 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Enclosure patch versus rev 915

Reported by: james@… Owned by: mbonetti
Priority: normal Milestone: Gregarius 0.5.5
Component: FEATURES Version:
Severity: normal Keywords: rss, enclosure, patch
Cc:

Description

The attached patch adds RSS 2.0 enclosure support. The patch does the following: * modifies magie parsing routine to check for enclosure element * modifies the item output to include the text ENCLOSURE as a link to the enclosure URL * modifies the db to add enclosure field to the item table

Possible future feature enhancement would be a setting to allow the user to specify a URL to which the enclosure URL would be appended.

Patch available here

Attachments

gregarius-enclosure-915.patch (9.5 kB) - added by james@… 3 years ago.
enclosure patch

Change History

Changed 3 years ago by james@…

enclosure patch

Changed 3 years ago by sdcosta

nice!! I shall test it out. Marco, what do you think?

Changed 3 years ago by ebyryan

Applied this to revision 925 and it appears to work well. Perhaps it would be better to return the enclosure URL itself and add the link, etc in the theme instead. This would allow the themes to handle the enclosures how they wish (buttons, embedding, etc.)

Changed 3 years ago by ebyryan

I updated and attached a patch to ticket 193 to play the mp3 inline using a flash file as discussed in the associated forum post. Works with this patch except I had it return the URL instead.

Changed 3 years ago by mbonetti

  • status changed from new to closed
  • resolution set to fixed

Applied James' patch (in [947]) thank you, James.

Note: See TracTickets for help on using tickets.