embedding flash player for mp3 files (podcasting)

[sdcosta]

We should have some kind of enclosure support for RSS 2.0 feeds in Gregarius.

http://forums.gregarius.net/comments.php?DiscussionID=7

[mbonetti]

James is about to send in an enclosure patch...

[ebyryan]

The patch was uploaded as Ticket 194. Would still be interesting to see inline mp3 support as outlined in the original discussion.

[ebyryan]

With the patch applied I edited the wrappers/item.php to return the URL instead. I downloaded the flash player to the media folder of the theme. I then changed the theme file to insert the object and append the URL. The flash file is under creative commons so not sure if the license will work. I've attached the patch to item.php (in the default theme folder). I've tested this and it works on revision 925 with the enclosure patch applied. I'm new at this patching business so bear with me.

[ebyryan]

Forgot to check if the item was an mp3 or not. It should probably display the link for non-mp3 items and embed if mp3. Not completely sure on what the best RegEx? for that would be.

And in case I wasn't clear I modified wrappers/item.php to return $enc instead of $ret as a temporary fix to get the URL.

[ebyryan]

updated to check for mp3 extension

[ebyryan]

Alright I edited it to check for mp3 extension. It will use the flash player if mp3 otherwise do the Enclosure link as is done in the enclosure patch. I think I got the diff almost right this time. You might have to specifically apply it to that item.php in the default theme folder. Sorry, still getting a hang of this.

[ebyryan]

BTW, the "$enc = rss_item_enclosure(); " line in the patch isn't needed. I was trying some other changes and forgot to take it out. Sorry bout that.