rss.output.numitemsonpage does not work for read items

[sdcosta]

If you set rss.output.numitemsonpage to a low number like 5 and you have no unread items gregarius renders your entire items table on the mainpage.

Similar things happen if you are viewing "read and unread" items. rss.output.numitemsonpage is not respected.

[sdcosta]

well I lied. it doesnt render the entire items table on the mainpage, but it feels like it is rendering the entire items table. Far more than 5 itmes though.

[mbonetti]

Odd, settinng rss.output.numitemsonpage to 5 renders exactly ... five items for me. Any other non-default configuration options you have set?

[sdcosta]

I just checked. I realised it is because rss.config.feedgrouping is set. Sorry I didn't realize earlier.

[mbonetti]

Okay. Should this ticket be closed, then?

[sdcosta]

well, I was under the impression that feed grouping just affects how the items are grouped. But rss.output.numitemsonpage should limit the number of items. With both these two things set, I expected to have numitems on the mainpage, sorted by date and grouped by feed.

Its your call.

[sdcosta]

ok I am very confused about what feedgrouping means. I have set it to false for now and I am happy :)

[sdcosta]

Show approx rss.output.numitemsonpage items when feedgrouping is set.

[sdcosta]

I set feedgrouping to true again and unhappiness returned. Feedgrouping means our nice "river of news" style. The only question is whether feedgrouping should respect rss.output.numitemsonpage on the mainpage. After much meditation and inner reflection I think it should. Attached a patch to show the kind of behavior I would like.

[ebyryan]

The patch does limit the recent items to fewer. In my test it lowered it to 4 even though I have the numitems set to 5. It also did not list recent items that I just read but instead listed the first two blogs and then the first 2 read items of each.

To be clear about my original request in the forums. When there are unread items the front page shows 5 unread items (respects the rss.output.numitemsonpage setting). When I'm done reading everything it goes back to the index with 'recent items'. This page displays everything I just read and does not respect the rss.output.numitemsonpage setting. I'd prefer that this only displayed 5 as well which is what I have it set to. Hope this is clearer.

I'm currently using revision 925.

[ebyryan]

It seems I misunderstood what the recent items page was showing. I thought it was items I had recently read though it appears to be the 2 most recent items for every feed. It would still be nice to limit this as I have 340 feeds at the moment. It might be good to hold off though as I don't know how others are using the recent items page. Pagination/limiting might be worthwhile. There's a related discussion forum topic for this item.

[sdcosta]

yes I know about getting fewer than rss.output.numitemsonpage. That can be fixed later.

My problem is that if you have 300 feeds and everything is read, then with feedgrouping set, the mainpage shows you 600 recent items. This patch just limits that to rss.output.numitemsonpage

I think you are asking for recent items to be items that you have recently read. AFAIK recent items means items that were published recently. I don't think gregarius keeps track of when you exactly you marked am item as read, so it has no idea of what was recently read.

[ebyryan]

That was just a confusion for me and is not really important what it shows as I don't use it. Limited the items so that it doesn't take 5 minutes to load is what I'm concerned about. I'm not sure if there should be a seperate limit or if it should be able to be turned off completely. Like I said I'd be happy with a page that just said "no unread items" but I'm uncertain how people use the recent items.

[sdcosta]

Yes, that is my goal also. I do not want the main page to load slowly when feedgrouping is set. So if we get feedgrouping to respect numitemsonpage, the problem will be solved.

[mbonetti]

Ok, I'm trying to keep track of this thread, both here and on the forums. Let me try to summarize things, please confirm this is how things should be:

• display at most rss.output.numitemsonpage unread items
• display (rss.output.numitemsonpage - unread_count) read items

And this regardless of whether feedgrouping is turned on or not.

What is happening though, is that when the latter is on Gregarius renders way too many read items.

So Sameer's patch seems to do the right thing. Is it not?

[sdcosta]

almost the right thing. It does not take into account feeds with just 1 item in it etc. It was just an example of the behaviour I wanted. This patch is slightly better. It will show numitemsonpage or numitemsonpage+1 I don't think there is any point in making it so that it gives exactly numitemsonpage items, but I can do it if you like.

[sdcosta]

this patch takes care of feeds with 1 or less items

[mbonetti]

Applied and tested Sameer's second patch [929], which is good. Thanks again, Sameer!