Ticket #187 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

& symbol in gregarius 0.5.2 RC3 produced feed

Reported by: tzitaroth@… Owned by: sdcosta
Priority: high Milestone: Gregarius 0.5.5
Component: BUGS Version: 2.0
Severity: trivial Keywords: encoding
Cc:

Description

Original feed: <title>1&amp;1: Dedizierte Server mit 64-Bit und ohne Traffic-Limit</title>

Gregarius-produced feed (invalid): <title>Golem.de: 1&1: Dedizierte Server mit 64-Bit und ohne Traffic-Limit</title>

Attachments

bbc.xml (14.3 kB) - added by sdcosta 3 years ago.
Test case

Change History

Changed 3 years ago by tzitaroth@…

  • milestone set to Gregarius 0.5.2

Changed 3 years ago by sdcosta

  • milestone Gregarius 0.5.2 deleted

I do not understand. Are you saying that the output of ?theme=rss has an incorrect title? or that the feed page has an incorrect title?

Changed 3 years ago by sdcosta

  • owner changed from mbonetti to sdcosta
  • status changed from new to assigned

Changed 3 years ago by mbonetti

  • keywords encoding added
  • component changed from BUGS to PLUGINS

Changed 3 years ago by sdcosta

  • status changed from assigned to closed
  • resolution set to fixed
  • component changed from PLUGINS to BUGS

The problem was in the title of an itemlist not in the ?theme=rss

Fixed (hopefully) in [911]

Changed 3 years ago by sdcosta

tzitaroth thanks for reporting this

Changed 3 years ago by tzitaroth

thanks for fixing it this quick. sorry for not being specific enough.

Changed 3 years ago by tzitaroth

  • status changed from closed to reopened
  • resolution fixed deleted

Unfortunately, the patch doesnt work. I now patched "item.php" in themes/rss/

<title><?php echo rss_feed_title(); ?>: <?php echo rss_item_title(); ?></title> to <title><?php echo rss_feed_title(); ?>: <?php echo rss_htmlspecialchars(rss_item_title()); ?></title>

which seems to produce valid rss output now. This is a workaround, but Im too unfamiliar with the project yet to fix the problem by myself.

Changed 3 years ago by sdcosta

ok I guess there was a problem in ?theme=rss also. I found one bug, so I just assumed that is what you meant. Sorry about that.

Changed 3 years ago by sdcosta

  • status changed from reopened to closed
  • resolution set to fixed

[913] should fix this problem. The same problem also occured in the default theme and should be fixed by this patch. Please re-open this ticket if there are any further issues.

Changed 3 years ago by sdcosta

  • status changed from closed to reopened
  • resolution fixed deleted

These changes are causing a problem. See #204

Changed 3 years ago by mbonetti

  • status changed from reopened to closed
  • resolution set to fixed

refixed in [940]. What do you think?

Changed 3 years ago by sdcosta

Test case

Changed 3 years ago by sdcosta

I have attached a test feed. The conditions to check are that the XHTML validator validates the page you are on (use the link on the bottom of that gregarius page). and the feed validator (feedvalidator.org) validates your feed.

Currently the second one is passed, but the first one isnt.

Changed 3 years ago by anonymous

  • status changed from closed to reopened
  • resolution fixed deleted
  • severity changed from normal to trivial
  • milestone set to Gregarius 0.5.2

Changed 3 years ago by mbonetti

  • priority changed from normal to high
  • milestone changed from Gregarius 0.5.2 to Gregarius 0.5.3

Changed 3 years ago by sdcosta

Might as well fix this at the same time....

http://weblog.philringnalda.com/2005/12/05/telling-markup-from-text

Changed 3 years ago by kkkkoaaa

  • version set to 2.0
  • summary changed from & symbol in gregarius 0.5.2 RC3 produced feed to &amp; symbol in gregarius 0.5.2 RC3 produced feed

Changed 3 years ago by mbonetti

  • status changed from reopened to closed
  • resolution set to fixed

Don't know when this was fixed, but the RSS feed for the test-case feed outputs. <code> <title> BBC News &amp; N morecrap new s adsfsd ews Front Page | UK Edition: NI soldiers 'face combat stress' </title> </code>

Note: See TracTickets for help on using tickets.