Changeset 1544 for trunk/gregarius/tags.php

Timestamp:

08/24/06 01:14:02 (4 years ago)

Author:

cfriesen

Message:

Feel free to scream if this breaks something...

Files:

• trunk/gregarius/tags.php (modified) (3 diffs)

trunk/gregarius/tags.php

@@ -36 +36 @@
     $twhere .= "1=0";
 
-    $sql = "select fid,tid,m.tdate from ".getTable('metatag')
-    ." m, ".getTable('tag')." t  where m.tid=t.id and m.ttype = 'item'"
+    $sql = "select fid,tid,m.tdate from ".getTable('metatag') ." m "
+  ."inner join " . getTable('tag') . " t on t.id = m.tid  where m.ttype = 'item'"
     ." and ($twhere)";
 
@@ -54 +54 @@
     if (count($fids)) {
         $sql = "select t.tag, count(*) as cnt from ".getTable('metatag')
-        ." m left join ".getTable('item')." i on (m.fid=i.id), "
-        .getTable('tag')." t "
-        ." where m.tid=t.id and m.fid in (".implode(",", $fids).")"
+        ." m left join ".getTable('item')." i on (m.fid=i.id) "
+        ." inner join " . getTable('tag')." t on (t.id = m.tid) "
+        ." where m.fid in (".implode(",", $fids).")"
         ." and t.id not in (".implode(",", $tids).")";
 
@@ -87 +87 @@
     $twhere .= " 1=0";
 
-    $sql = "select fid, count(*) as cnt from "
-    .getTable('metatag')." m, "
-    .getTable('tag')." t "
-    ." where m.tid=t.id and ($twhere) "
+    $sql = "select fid, count(*) as cnt from " . getTable('metatag')." m "
+    ."inner join " . getTable('tag')." t on t.id = m.tid "
+    ." where ($twhere) "
     ." and m.ttype = 'item'"
     ." group by fid order by 2 desc";